Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_uri: stop output from mixing with module result #48140

Merged
merged 1 commit into from
Nov 6, 2018
Merged

win_uri: stop output from mixing with module result #48140

merged 1 commit into from
Nov 6, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

The .Seek() methods return the new position offset of the stream and that is being sent to the output pipe. We need to pipe that to $null so Ansible isn't confused when trying to read the module results.

Fixes #47998

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_uri

ANSIBLE VERSION
devel

@ansibot
Copy link
Contributor

ansibot commented Nov 6, 2018

Hi @jborean93, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 6, 2018

cc @dagwieers @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community labels Nov 6, 2018
@jborean93 jborean93 merged commit 8a9d7b3 into ansible:devel Nov 6, 2018
@jborean93 jborean93 deleted the win_uri-output branch November 6, 2018 01:10
jborean93 added a commit to jborean93/ansible that referenced this pull request Nov 6, 2018
@jborean93
win_uri: stop output from mixing with module result (ansible#48140)
9e93f3a 
(cherry picked from commit 8a9d7b3)
jborean93 added a commit to jborean93/ansible that referenced this pull request Nov 6, 2018
@jborean93
win_uri: stop output from mixing with module result (ansible#48140)
561bf80 
(cherry picked from commit 8a9d7b3)
This was referenced Nov 6, 2018
Merged
Merged
@jborean93
Copy link
Contributor Author

Backport PRs
stable-2.6 #48142
stable-2.7 #48143

@jborean93 jborean93 mentioned this pull request Nov 6, 2018
Closed
abadger pushed a commit that referenced this pull request Nov 6, 2018
@jborean93 @abadger
win_uri: stop output from mixing with module result (#48140)
90fe1be 
(cherry picked from commit 8a9d7b3)
mattclay pushed a commit that referenced this pull request Nov 6, 2018
@jborean93 @mattclay
win_uri: stop output from mixing with module result (#48140)
618beca 
(cherry picked from commit 8a9d7b3)
@mkrizek mkrizek removed needs_triage Needs a first human triage before being processed. labels Nov 6, 2018
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@jborean93 @mjmayer
win_uri: stop output from mixing with module result (ansible#48140)
1a0f162
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@jborean93 @Tomorrow9
win_uri: stop output from mixing with module result (ansible#48140)
4af11e0
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

win_uri fails when retrieving plaintext result
3 participants
@jborean93 @ansibot @mkrizek